-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move wallet manager "zero balance" check to transaction handlers #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move it into default transaction handler allowing it to be overriden for example by htlc claim/refund
Codecov Report
@@ Coverage Diff @@
## develop #2896 +/- ##
===========================================
- Coverage 68.12% 68.08% -0.04%
===========================================
Files 405 405
Lines 9734 9733 -1
Branches 459 460 +1
===========================================
- Hits 6631 6627 -4
- Misses 3067 3069 +2
- Partials 36 37 +1
Continue to review full report at Codecov.
|
spkjp
previously approved these changes
Aug 30, 2019
spkjp
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the database wallet manager "zero balance" check to transaction handlers.
Fixes issue with HTLC transactions where we authorize a sender to send HTLC claim or refund transaction with no balance.
Added e2e tests for htlc claim and refund.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
develop
branch, not themaster
branchIf adding a new feature, the PR's description includes: