feat(crypto): add multiSignWif to transaction builder #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spkjp
requested review from
air1one,
faustbrian and
kristjank
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2979 +/- ##
===========================================
+ Coverage 66.01% 66.02% +<.01%
===========================================
Files 420 420
Lines 10044 10046 +2
Branches 510 511 +1
===========================================
+ Hits 6631 6633 +2
Misses 3371 3371
Partials 42 42
Continue to review full report at Codecov.
|
ghost
mentioned this pull request
ghost
deleted the
vasild
added a commit
that referenced
this pull request
Oct 1, 2019
…ts-nonce * ArkEcosystem/core/develop: fix(deps): update dependency @hapi/boom to v8 (#2988) feat(crypto): allow passing height to `configManager.isNewMilestone` (#3001) ci: update branch patterns to new format refactor: remove asset migration heuristic (#2999) chore(deps): update dependency typesync to ^0.6.0 (#2981) refactor(core): use default heap size regardless of available memory (#2998) chore(deps): update dependency cross-env to v6 (#2985) chore(deps): update dependency rimraf to v3 (#2987) refactor: core-magistrate-crypto export namespaces (#2980) feat: multiSignWif (#2979) fix(core-snapshots): export/import transactions' type_group (#2996) chore(deps): update dependency @types/newrelic to v5 (#2984) fix(deps): update dependency node-forge to ^0.9.0 (#2983) feat(core-api): find htlc unlock transactions (#2976) chore(deps): update dependency del-cli to v3 (#2986) fix(deps): update dependency cli-progress to v3 (#2990) fix(deps): update dependency winston-daily-rotate-file to v4 (#2992) fix(core-api): missing orderBy (#2974) feat(core): allow CLI command configurations (#2972) refactor(core-magistrate): Split core-marketplace into core-magistrate-crypto and core-magistrate-transactions (#2967)
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Complements
signWifandsecondSignWifby addingmultiSignWifto the transaction builder.Checklist