Block schema validation #3062
Merged
Block schema validation #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasild
requested review from
air1one,
faustbrian,
kristjank and
spkjp
as code owners
ghost
added
the
Check each schema error: * if it originated from the block, then the block must be an exception * if it originated from a transaction, then the transaction must be an exception Also print the value should validation fail to make it easier to diagnose problems.
vasild
force-pushed
the
block-schema-validation
branch
from
effb631
to
a7cf6fb
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3062 +/- ##
===========================================
+ Coverage 65.62% 65.67% +0.04%
===========================================
Files 425 425
Lines 11734 11744 +10
Branches 1602 1605 +3
===========================================
+ Hits 7701 7713 +12
+ Misses 3997 3995 -2
Partials 36 36
Continue to review full report at Codecov.
|
spkjp
approved these changes
Oct 14, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(crypto): strengthen schema validation checks
Check each schema error:
exception
Also print the value should validation fail to make it easier to
diagnose problems.