Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-tester-cli): support nonces and chunk transactions before broadcast #3081

Merged
merged 3 commits into from
Oct 17, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Oct 17, 2019

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #3081 into develop will increase coverage by 36.14%.
The diff coverage is 90%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3081       +/-   ##
============================================
+ Coverage    29.64%   65.79%   +36.14%     
============================================
  Files          425      425               
  Lines        11755    11779       +24     
  Branches      1608     1612        +4     
============================================
+ Hits          3485     7750     +4265     
+ Misses        8239     3994     -4245     
- Partials        31       35        +4
Impacted Files Coverage Δ
...ackages/core-tester-cli/src/commands/make/block.ts 94.11% <ø> (ø) ⬆️
packages/core-tester-cli/src/signer.ts 88.88% <100%> (+2.88%) ⬆️
packages/core-tester-cli/src/commands/command.ts 64.7% <81.25%> (+2.54%) ⬆️
packages/core-tester-cli/src/http-client.ts 92.85% <0%> (+7.14%) ⬆️
packages/crypto/src/utils/base58.ts 100% <0%> (+7.14%) ⬆️
...ckages/core-transaction-pool/src/wallet-manager.ts 100% <0%> (+8%) ⬆️
...ckages/core-transactions/src/transaction-reader.ts 8.33% <0%> (+8.33%) ⬆️
packages/crypto/src/transactions/types/factory.ts 100% <0%> (+8.33%) ⬆️
packages/core-container/src/config/file-loader.ts 10.86% <0%> (+10.86%) ⬆️
packages/core-transaction-pool/src/manager.ts 100% <0%> (+11.11%) ⬆️
... and 193 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bcc8fa...17e5eac. Read the comment docs.

@faustbrian faustbrian changed the title fix(core-tester-cli): support nonces and chunk transactions before broadcast fix(core-tester-cli): support nonces and chunk transactions before broadcast Oct 17, 2019
@faustbrian faustbrian merged commit 32e03d0 into develop Oct 17, 2019
@ghost ghost deleted the fix/core-tester-cli branch October 17, 2019 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants