Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-event-emitter): add stateBuilder.finished to ApplicationEvents #3084

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Oct 17, 2019

Summary

Resolves #3012

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #3084 into develop will increase coverage by 36.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3084       +/-   ##
============================================
+ Coverage    29.64%   65.73%   +36.08%     
============================================
  Files          425      425               
  Lines        11755    11756        +1     
  Branches      1608     1608               
============================================
+ Hits          3485     7728     +4243     
+ Misses        8239     3993     -4246     
- Partials        31       35        +4
Impacted Files Coverage Δ
...ckages/core-database-postgres/src/state-builder.ts 85.71% <100%> (+0.29%) ⬆️
packages/core-transaction-pool/src/connection.ts 92.37% <100%> (+35.59%) ⬆️
packages/crypto/src/utils/base58.ts 100% <0%> (+7.14%) ⬆️
...ckages/core-transaction-pool/src/wallet-manager.ts 100% <0%> (+8%) ⬆️
...ckages/core-transactions/src/transaction-reader.ts 8.33% <0%> (+8.33%) ⬆️
packages/crypto/src/transactions/types/factory.ts 100% <0%> (+8.33%) ⬆️
packages/core-container/src/config/file-loader.ts 10.86% <0%> (+10.86%) ⬆️
packages/core-transaction-pool/src/manager.ts 100% <0%> (+11.11%) ⬆️
packages/crypto/src/transactions/utils.ts 93.75% <0%> (+12.5%) ⬆️
packages/core-utils/src/httpie.ts 12.9% <0%> (+12.9%) ⬆️
... and 191 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bcc8fa...75cc07c. Read the comment docs.

@faustbrian faustbrian merged commit f05fd6a into develop Oct 17, 2019
@ghost ghost deleted the refactor/core-event-emitter/state-finished branch October 17, 2019 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants