Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-transaction-pool): create new wallet if not found #3086

Merged
merged 1 commit into from
Oct 19, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Oct 19, 2019

Summary

If the database wallet manager doesn't know the wallet we have to create a new one.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Oct 19, 2019

Codecov Report

Merging #3086 into develop will decrease coverage by 0.01%.
The diff coverage is 37.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3086      +/-   ##
===========================================
- Coverage    65.73%   65.72%   -0.02%     
===========================================
  Files          425      425              
  Lines        11792    11797       +5     
  Branches      1613     1615       +2     
===========================================
+ Hits          7752     7754       +2     
- Misses        4005     4008       +3     
  Partials        35       35
Impacted Files Coverage Δ
packages/core-database/src/database-service.ts 26.46% <0%> (ø) ⬆️
...ages/core-state/src/wallets/temp-wallet-manager.ts 76.47% <50%> (-6.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee79f3f...b020bf2. Read the comment docs.

@faustbrian faustbrian merged commit e928df7 into develop Oct 19, 2019
@ghost ghost deleted the fix/core-transaction-pool/wallet-fallback branch October 19, 2019 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants