Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): discover peers when checking network health #3358

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Dec 19, 2019

Summary

A fork recovery's success depends on the number of available peers, so we should ensure enough peers are available.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #3358 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3358      +/-   ##
===========================================
+ Coverage    66.07%   66.07%   +<.01%     
===========================================
  Files          438      438              
  Lines        12263    12264       +1     
  Branches      1655     1655              
===========================================
+ Hits          8103     8104       +1     
  Misses        4127     4127              
  Partials        33       33
Impacted Files Coverage Δ
packages/core-p2p/src/network-monitor.ts 73.35% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 224dcd5...f698558. Read the comment docs.

@faustbrian faustbrian merged commit 68e1c9d into develop Dec 20, 2019
@ghost ghost deleted the refactor/core-p2p/discover-peers branch December 20, 2019 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants