fix(core-blockchain): pass IBlockData to processBlocks instead of IBlock #3426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pass IBlockData to processBlocks instead of IBlock, to only create instance of IBlock when actually processing the block : this fixes an issue when reaching a new milestone in the middle of the downloaded blocks, as creating instance of IBlock verifies the transactions within it according to the current milestone.
Checklist