Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-transactions): apply genesis wallet exception to lastForgedBlocks #3440

Merged
merged 2 commits into from Feb 6, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Feb 6, 2020

Summary

Fix "genesis wallet" case that was correctly handled for forgedBlocks but not for lastForgedBlocks.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #3440 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3440      +/-   ##
===========================================
- Coverage    66.17%   66.16%   -0.01%     
===========================================
  Files          439      439              
  Lines        12454    12456       +2     
  Branches      1706     1707       +1     
===========================================
+ Hits          8241     8242       +1     
- Misses        4179     4180       +1     
  Partials        34       34
Impacted Files Coverage Δ
...transactions/src/handlers/delegate-registration.ts 41.42% <0%> (-1.22%) ⬇️
packages/core-transaction-pool/src/storage.ts 100% <0%> (+2.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f20abf4...27817f8. Read the comment docs.

@faustbrian faustbrian merged commit 6dbae81 into develop Feb 6, 2020
@faustbrian faustbrian deleted the fix/core-transactions/delegate-registration branch February 6, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants