Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add flag to skip export of rolled back transactions #3459

Merged
merged 2 commits into from
Feb 13, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Feb 10, 2020

Summary

This PR adds an additional flag (--export / --no-export) to the snapshot:rollback command which allows to skip the export of rolled back transactions.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost
Copy link

ghost commented Feb 10, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Low labels Feb 10, 2020
@dated
Copy link
Contributor Author

dated commented Feb 10, 2020

Unrelated failure:

FAIL __tests__/integration/core-p2p/socket-server/peer.test.ts (71.286s)
  ● Peer socket endpoint › Socket errors › should close the connection if it sends data after a disconnect packet

    expect(received).toBe(expected) // Object.is equality

    Expected: "open"
    Received: "closed"

      496 |             await delay(1000);
      497 | 
    > 498 |             expect(socket.state).toBe("open");
          |                                  ^
      499 | 
      500 |             send('{"event":"#disconnect","data":{"code":4000}}');
      501 |             await expect(

      at Object.<anonymous> (__tests__/integration/core-p2p/socket-server/peer.test.ts:498:34)

@air1one
Copy link
Contributor

air1one commented Feb 13, 2020

hey @dated can you create a new PR for this against the 2.6 branch ? thanks !

@faustbrian faustbrian changed the base branch from develop to 2.6 February 13, 2020 08:09
@dated
Copy link
Contributor Author

dated commented Feb 13, 2020

thanks @faustbrian!

@ghost
Copy link

ghost commented Feb 13, 2020

A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@air1one air1one merged commit b88806f into ArkEcosystem:2.6 Feb 13, 2020
@ghost
Copy link

ghost commented Feb 13, 2020

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@ghost
Copy link

ghost commented Feb 13, 2020

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@dated dated deleted the feat/rollback-no-export branch February 13, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants