Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-manager): implement snapshots.create action #3728

Merged
merged 2 commits into from May 25, 2020

Conversation

sebastijankuzner
Copy link
Contributor

Summary

This PR add new action which creates snapshot with given parameters. PR also implements snapshot-manager which prevents snapshot action to run in parallel and can be later extended to keep record of the process status (eg: percentage of restored blocks).

Action

Name: snapshots.create

Params:

Name Type Description
codec String (Optional; Default: default) Codec name eg: default, json
skipCompression Boolean (Optional: Default: false) Skip zlib snapshot compression?
start Number (Optional) Number of first block included in snaphsot *
start Number (Optional) Number of last block included in snaphsot *

Response:: Empty response if snapshot process is started successfully. It doesn't guarantee that snapshot process completed successfully.

(*) Block height is later re-calculated to match nearest round start.

Checklist

  • Tests
  • Ready to be merged

@faustbrian faustbrian merged commit 82382fc into develop May 25, 2020
@ghost ghost deleted the feat/core-manager/snapshot-create branch May 25, 2020 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants