Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core-api): set default orderBy value #3777

Merged
merged 1 commit into from Jun 7, 2020
Merged

fix(core-api): set default orderBy value #3777

merged 1 commit into from Jun 7, 2020

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Jun 5, 2020

Summary

Order transactions and blocks in reverse chronological order by default.

Checklist

  • Ready to be merged

@ghost ghost added Complexity: Low labels Jun 5, 2020
@rainydio
Copy link
Contributor Author

rainydio commented Jun 5, 2020

Ordering is done on core-api level which is incorrect, but can be implemented quickly. Ordering on core-database makes more sense, but isn't implemented yet.

@rainydio rainydio marked this pull request as ready for review June 5, 2020 12:08
@faustbrian faustbrian merged commit 9ea9bb4 into develop Jun 7, 2020
@ghost ghost deleted the fix/core-api/default-order-by branch June 7, 2020 02:14
@ghost ghost removed the Status: Needs Review label Jun 7, 2020
@ghost ghost mentioned this pull request Jun 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@air1one air1one Awaiting requested review from air1one

@faustbrian faustbrian Awaiting requested review from faustbrian

@kristjank kristjank Awaiting requested review from kristjank

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rainydio @faustbrian