-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core-manager): fix configuration and plugin actions #3788
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3788 +/- ##
===========================================
- Coverage 87.98% 86.25% -1.74%
===========================================
Files 617 616 -1
Lines 13618 13611 -7
Branches 1541 1543 +2
===========================================
- Hits 11982 11740 -242
- Misses 481 733 +252
+ Partials 1155 1138 -17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Watching for events should never be enabled by default, no matter the network. Using those watchers is targeted specifically at developers that want more insight or heavy logging, not the average user.
Summary
This PR introduces fixes for configuring core-manager. Watching for events, logs etc. is only enabled on testnet and devnet by default and it does not start RPC servers. In contrast, when running manager instance, watcher is disabled and RPC server is running.
Since package.js configuration file is deprecated, reponsible get and update plugin actions now reads and writes configuration data into app.json file.
Argon2id action is removed, because it was only used for testing.
Checklist