Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core-manager): fix configuration and plugin actions #3788

Merged
merged 8 commits into from
Jun 11, 2020

Conversation

sebastijankuzner
Copy link
Contributor

@sebastijankuzner sebastijankuzner commented Jun 10, 2020

Summary

This PR introduces fixes for configuring core-manager. Watching for events, logs etc. is only enabled on testnet and devnet by default and it does not start RPC servers. In contrast, when running manager instance, watcher is disabled and RPC server is running.

Since package.js configuration file is deprecated, reponsible get and update plugin actions now reads and writes configuration data into app.json file.

Argon2id action is removed, because it was only used for testing.

Checklist

  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #3788 into develop will decrease coverage by 1.73%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3788      +/-   ##
===========================================
- Coverage    87.98%   86.25%   -1.74%     
===========================================
  Files          617      616       -1     
  Lines        13618    13611       -7     
  Branches      1541     1543       +2     
===========================================
- Hits         11982    11740     -242     
- Misses         481      733     +252     
+ Partials      1155     1138      -17     
Impacted Files Coverage Δ
.../core-manager/src/actions/configuration-get-env.ts 0.00% <ø> (ø)
...e-manager/src/actions/configuration-get-plugins.ts 0.00% <0.00%> (-100.00%) ⬇️
...anager/src/actions/configuration-update-plugins.ts 0.00% <0.00%> (-85.00%) ⬇️
packages/core-manager/src/database-service.ts 0.00% <0.00%> (-83.61%) ⬇️
packages/core-manager/src/service-provider.ts 0.00% <0.00%> (-92.00%) ⬇️
packages/core/src/commands/core-run.ts 100.00% <ø> (ø)
packages/core-manager/src/listener.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-manager/src/action-reader.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-manager/src/database-logger.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-manager/src/ioc/identifiers.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a2033a...efcb33a. Read the comment docs.

Copy link
Contributor

@faustbrian faustbrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watching for events should never be enabled by default, no matter the network. Using those watchers is targeted specifically at developers that want more insight or heavy logging, not the average user.

@faustbrian faustbrian merged commit d0650b1 into develop Jun 11, 2020
@ghost ghost deleted the chore/core-manager/configuration branch June 11, 2020 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants