Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-api): fix transaction resource responses #3794

Merged
merged 1 commit into from
Jun 13, 2020

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Jun 12, 2020

Summary

Fixes #3758 and #3759.

Fixed transaction resource responses. Added confirmations and timestamp fields. Same as before. This is a temporary solution until I can make a better one that doesn't require so much handling on API level.

Checklist

  • Ready to be merged

@rainydio rainydio changed the base branch from master to develop June 12, 2020 10:48
@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #3794 into develop will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3794      +/-   ##
===========================================
+ Coverage    96.86%   96.88%   +0.01%     
===========================================
  Files          616      616              
  Lines        13861    13897      +36     
  Branches      1672     1677       +5     
===========================================
+ Hits         13427    13464      +37     
  Misses         145      145              
+ Partials       289      288       -1     
Flag Coverage Δ
#functional 6.21% <0.00%> (-0.02%) ⬇️
#integration 10.15% <70.00%> (+0.12%) ⬆️
#unit 95.08% <70.00%> (-0.10%) ⬇️
Impacted Files Coverage Δ
packages/core-api/src/controllers/transactions.ts 100.00% <100.00%> (ø)
packages/core-api/src/controllers/wallets.ts 100.00% <100.00%> (ø)
packages/core-p2p/src/network-monitor.ts 98.05% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b68d5f...b11f54c. Read the comment docs.

@faustbrian faustbrian merged commit b3e0b98 into develop Jun 13, 2020
@ghost ghost deleted the fix/core-api/transaction-resource-responses branch June 13, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants