Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-transactions): remove custom wallet repository #3803

Merged

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Jun 16, 2020

Summary

Custom wallet repository was pool isolation technique that was replaced back in March. Since then customWalletRepository wasn't passed into handlers, but handlers weren't updated to remove unnecessary parameter. All mentions of customWalletRepository are now removed making handlers slightly more straightforward.

Checklist

  • Documentation is there anything that needs to be updated?
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #3803 into develop will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3803      +/-   ##
===========================================
+ Coverage    96.92%   97.12%   +0.19%     
===========================================
  Files          616      616              
  Lines        13999    13946      -53     
  Branches      1688     1634      -54     
===========================================
- Hits         13569    13545      -24     
  Misses         137      137              
+ Partials       293      264      -29     
Flag Coverage Δ
#functional 6.41% <0.00%> (+0.02%) ⬆️
#integration 10.13% <0.00%> (+0.03%) ⬆️
#unit 95.10% <100.00%> (+0.18%) ⬆️
Impacted Files Coverage Δ
...s/src/handlers/one/multi-signature-registration.ts 95.83% <ø> (ø)
...nsactions/src/handlers/bridgechain-registration.ts 95.77% <100.00%> (-0.18%) ⬇️
...ansactions/src/handlers/bridgechain-resignation.ts 98.27% <100.00%> (+1.60%) ⬆️
...te-transactions/src/handlers/bridgechain-update.ts 94.93% <100.00%> (+1.10%) ⬆️
...transactions/src/handlers/business-registration.ts 100.00% <100.00%> (+2.43%) ⬆️
...-transactions/src/handlers/business-resignation.ts 100.00% <100.00%> (+2.56%) ⬆️
...trate-transactions/src/handlers/business-update.ts 97.91% <100.00%> (+1.91%) ⬆️
...ore-magistrate-transactions/src/handlers/entity.ts 73.68% <100.00%> (+5.39%) ⬆️
...te-transactions/src/handlers/magistrate-handler.ts 100.00% <100.00%> (ø)
...sactions/src/handlers/one/delegate-registration.ts 90.90% <100.00%> (+1.54%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 507f811...7670886. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants