-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core-api): use shorter default timeouts #3804
Conversation
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
Codecov Report
@@ Coverage Diff @@
## develop #3804 +/- ##
===========================================
+ Coverage 96.92% 97.28% +0.36%
===========================================
Files 616 617 +1
Lines 14000 13908 -92
Branches 1688 1631 -57
===========================================
- Hits 13570 13531 -39
+ Misses 137 117 -20
+ Partials 293 260 -33
Continue to review full report at Codecov.
|
A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
Your pull request has been merged. Thank you for your contribution to the ARK Ecosystem. |
Summary
This PR stops a user from opening and keeping open multiple long lived TCP connections to the public API server which is enabled by default. It prevents server resource starvation by implementing a shorter maximum timeout (default: 5 seconds) so connections will be closed if no request is received after that time.