Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-database): return serialized transactions #3824

Merged

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Jun 23, 2020

Summary

Return serialized transactions in findByHeightRangeWithTransactions as it's expected (same as in v2.6).

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #3824 into develop will increase coverage by 7.56%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3824      +/-   ##
===========================================
+ Coverage    84.30%   91.87%   +7.56%     
===========================================
  Files          620      620              
  Lines        14769    14768       -1     
  Branches      1842     1842              
===========================================
+ Hits         12451    13568    +1117     
+ Misses        2086      939    -1147     
- Partials       232      261      +29     
Flag Coverage Δ
#functional 6.10% <100.00%> (-0.01%) ⬇️
#integration 9.60% <0.00%> (+<0.01%) ⬆️
#unit 89.93% <0.00%> (+7.78%) ⬆️
Impacted Files Coverage Δ
...core-database/src/repositories/block-repository.ts 96.92% <100.00%> (-0.05%) ⬇️
packages/core-p2p/src/hapi-nes/client.ts 2.83% <0.00%> (+2.83%) ⬆️
packages/core-p2p/src/hapi-nes/socket.ts 2.89% <0.00%> (+2.89%) ⬆️
packages/core-p2p/src/hapi-nes/listener.ts 3.93% <0.00%> (+3.93%) ⬆️
packages/core-p2p/src/peer.ts 100.00% <0.00%> (+41.66%) ⬆️
...ore-p2p/src/socket-server/utils/get-peer-config.ts 79.31% <0.00%> (+79.31%) ⬆️
packages/core-p2p/src/peer-processor.ts 90.90% <0.00%> (+90.90%) ⬆️
.../core-p2p/src/socket-server/plugins/accept-peer.ts 90.90% <0.00%> (+90.90%) ⬆️
...ges/core-p2p/src/socket-server/plugins/validate.ts 91.66% <0.00%> (+91.66%) ⬆️
packages/core-p2p/src/peer-verifier.ts 99.42% <0.00%> (+93.14%) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79a1dd...7d90e74. Read the comment docs.

@faustbrian faustbrian merged commit 7e369b1 into develop Jun 23, 2020
@ghost ghost deleted the fix/core-database/findByHeightRangeWithTransactions branch June 23, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants