Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-manager): disable individual watchers #3829

Merged
merged 3 commits into from
Jun 25, 2020

Conversation

sebastijankuzner
Copy link
Contributor

Summary

This PR implements additional logic for enabling and disabling single watcher component using environment variables.

List of env variables:

  • CORE_WATCH_BLOCKS_DISABLED,
  • CORE_WATCH_ERRORS_DISABLED,
  • CORE_WATCH_LOGS_DISABLED,
  • CORE_WATCH_QUERIES_DISABLED,
  • CORE_WATCH_QUEUES_DISABLED,
  • CORE_WATCH_ROUNDS_DISABLED,
  • CORE_WATCH_SCHEDULES_DISABLED,
  • CORE_WATCH_TRANSACTIONS_DISABLED,
  • CORE_WATCH_WALLETS_DISABLED,
  • CORE_WATCH_WEBHOOKS_DISABLED,

Checklist

  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #3829 into develop will decrease coverage by 7.46%.
The diff coverage is 89.28%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3829      +/-   ##
===========================================
- Coverage    91.87%   84.41%   -7.47%     
===========================================
  Files          620      620              
  Lines        14768    14788      +20     
  Branches      1842     1853      +11     
===========================================
- Hits         13568    12483    -1085     
- Misses         939     2055    +1116     
+ Partials       261      250      -11     
Flag Coverage Δ
#functional 6.09% <0.00%> (-0.01%) ⬇️
#integration 9.58% <0.00%> (-0.02%) ⬇️
#unit 82.47% <89.28%> (-7.46%) ⬇️
Impacted Files Coverage Δ
packages/core-manager/src/service-provider.ts 94.33% <66.66%> (-1.67%) ⬇️
packages/core-manager/src/listener.ts 100.00% <100.00%> (ø)
packages/core-kernel/src/container.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-kernel/src/services/mixins/mixins.ts 0.00% <0.00%> (-100.00%) ⬇️
...kages/core-kernel/src/services/log/drivers/null.ts 0.00% <0.00%> (-100.00%) ⬇️
...ges/core-kernel/src/services/cache/drivers/null.ts 0.00% <0.00%> (-100.00%) ⬇️
...ges/core-kernel/src/services/queue/drivers/null.ts 0.00% <0.00%> (-100.00%) ⬇️
.../core-kernel/src/services/pipeline/drivers/null.ts 0.00% <0.00%> (-100.00%) ⬇️
...ore-kernel/src/services/filesystem/drivers/null.ts 0.00% <0.00%> (-100.00%) ⬇️
...ore-kernel/src/services/mixins/service-provider.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e369b1...941b603. Read the comment docs.

@faustbrian faustbrian changed the title feat(core-manager): disable single watcher feat(core-manager): disable individual watchers Jun 25, 2020
@faustbrian faustbrian merged commit e943e56 into develop Jun 25, 2020
@ghost ghost deleted the feat/core-watcher/toogle-watchers branch June 25, 2020 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants