Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-kernel): prevent watcher from calling app.reboot multiple times #3834

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Jun 26, 2020

Summary

Watcher was calling app.reboot for every file that was changed.

Checklist

  • Ready to be merged

@ghost ghost added Complexity: Low labels Jun 26, 2020
@rainydio rainydio changed the title fix(core-kernel): prevent watcher from calling app.reboot multiple times fix(core-kernel): prevent watcher from calling app.reboot for every changed file Jun 26, 2020
@rainydio rainydio changed the title fix(core-kernel): prevent watcher from calling app.reboot for every changed file fix(core-kernel): prevent watcher from calling app.reboot multiple times Jun 26, 2020
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #3834 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3834   +/-   ##
========================================
  Coverage    91.87%   91.87%           
========================================
  Files          620      620           
  Lines        14787    14788    +1     
  Branches      1853     1853           
========================================
+ Hits         13585    13586    +1     
  Misses         938      938           
  Partials       264      264           
Flag Coverage Δ
#functional 6.09% <0.00%> (-0.01%) ⬇️
#integration 9.58% <0.00%> (-0.01%) ⬇️
#unit 89.93% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
...ackages/core-kernel/src/services/config/watcher.ts 91.66% <100.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e943e56...9c6a301. Read the comment docs.

@rainydio rainydio marked this pull request as ready for review June 26, 2020 07:49
@faustbrian faustbrian merged commit 0d4b210 into develop Jun 26, 2020
@ghost ghost deleted the fix/core-kernel/watcher-multi-app-reboot branch June 26, 2020 12:41
@ghost ghost removed the Status: Needs Review label Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants