Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core-manager): increase coverage to 100% #3837

Merged
merged 8 commits into from
Jun 26, 2020

Conversation

sebastijankuzner
Copy link
Contributor

Summary

Increase coverage or core-manager package.

Checklist

  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #3837 into develop will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3837      +/-   ##
===========================================
+ Coverage    91.87%   91.99%   +0.11%     
===========================================
  Files          620      620              
  Lines        14787    14795       +8     
  Branches      1853     1849       -4     
===========================================
+ Hits         13585    13610      +25     
  Misses         938      938              
+ Partials       264      247      -17     
Flag Coverage Δ
#functional 6.08% <0.00%> (-0.01%) ⬇️
#integration 9.59% <0.00%> (+<0.01%) ⬆️
#unit 90.05% <100.00%> (+0.12%) ⬆️
Impacted Files Coverage Δ
packages/core-manager/src/database-service.ts 100.00% <ø> (+6.34%) ⬆️
packages/core-manager/src/actions/process.stop.ts 100.00% <100.00%> (+8.33%) ⬆️
...ckages/core-manager/src/server/validators/token.ts 100.00% <100.00%> (+20.00%) ⬆️
packages/core-manager/src/watcher-wallet.ts 100.00% <100.00%> (+12.50%) ⬆️
packages/core-p2p/src/peer-verifier.ts 99.42% <0.00%> (ø)
packages/core-kernel/src/application.ts 100.00% <0.00%> (ø)
packages/core-p2p/src/utils/check-ntp.ts 100.00% <0.00%> (ø)
packages/core-state/src/state-builder.ts 100.00% <0.00%> (ø)
packages/core-p2p/src/socket-server/server.ts 100.00% <0.00%> (ø)
...tstrap/service-providers/boot-service-providers.ts 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e943e56...7752dce. Read the comment docs.

@air1one air1one merged commit 196c501 into develop Jun 26, 2020
@ghost ghost deleted the test/core-manager/increase-coverage branch June 26, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants