Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-transactions): stream transactions during bootstrap #3844

Merged
merged 28 commits into from
Jul 1, 2020

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Jun 29, 2020

Summary

Bootstrap implementations that used reader were limited to 1000000000 transactions only. There was a comment mentioning that and suggesting to use streams.

  • streamByCriteria method was added to transaction history service.
  • getTransactionReader was removed from base transaction handler.
  • Every bootstrap implementation that used reader was updated.
  • Entity handler received bootstrap implementation that it was missing.
  • Multi-signature handlers have different implementations and now correctly load transactions by version.
  • Added new attribute multiSignature.legacy set by legacy multi-signature handler.

Checklist

  • Tests
  • Ready to be merged

@ghost ghost added Complexity: High labels Jun 29, 2020
@rainydio rainydio marked this pull request as draft June 29, 2020 06:29
@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #3844 into develop will decrease coverage by 0.05%.
The diff coverage is 76.15%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3844      +/-   ##
===========================================
- Coverage    92.14%   92.09%   -0.06%     
===========================================
  Files          621      620       -1     
  Lines        14826    14845      +19     
  Branches      1831     1847      +16     
===========================================
+ Hits         13662    13671       +9     
+ Misses         952      951       -1     
- Partials       212      223      +11     
Flag Coverage Δ
#functional 6.10% <3.97%> (+0.03%) ⬆️
#integration 9.56% <0.66%> (-0.01%) ⬇️
#unit 90.12% <72.84%> (-0.09%) ⬇️
Impacted Files Coverage Δ
...ctions/src/handlers/entity-subhandlers/register.ts 63.15% <0.00%> (-5.42%) ⬇️
...sactions/src/handlers/entity-subhandlers/resign.ts 65.78% <0.00%> (-3.66%) ⬇️
...sactions/src/handlers/entity-subhandlers/update.ts 77.35% <0.00%> (-3.04%) ⬇️
...core-transactions/src/handlers/handler-provider.ts 100.00% <ø> (ø)
...ore-magistrate-transactions/src/handlers/entity.ts 59.57% <18.18%> (+7.78%) ⬆️
...ackages/core-transactions/src/handlers/two/ipfs.ts 85.71% <75.00%> (-1.79%) ⬇️
...s/src/handlers/two/multi-signature-registration.ts 90.38% <75.00%> (-1.78%) ⬇️
...trate-transactions/src/handlers/business-update.ts 95.91% <81.81%> (-2.00%) ⬇️
...nsactions/src/handlers/bridgechain-registration.ts 94.59% <83.33%> (-1.19%) ⬇️
...te-transactions/src/handlers/bridgechain-update.ts 93.90% <83.33%> (-1.04%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e9f76e...04ccf0b. Read the comment docs.

@rainydio rainydio marked this pull request as ready for review July 1, 2020 09:38
@rainydio
Copy link
Contributor Author

rainydio commented Jul 1, 2020

It appears as coverage errors are false-positives

Copy link
Contributor

@air1one air1one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the comments and we're good 👍

@air1one air1one merged commit 8a6be81 into develop Jul 1, 2020
@ghost ghost deleted the fix/core-transactions/bootstrap-stream branch July 1, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants