chore(core-snapshots): skip verification of transactions sent from multisignature wallets #3846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastijankuzner
requested review from
air1one,
faustbrian and
kristjank
as code owners
ghost
added
faustbrian
approved these changes
Jun 29, 2020
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #3538
Validation of transaction from multisignature wallets is skipped, because it will require additional logic, applying transactions and using wallet registry. Because core-snapshots should stay simple, lightweight and fast as possible we don't check those transactions. They should be validated on the node boot.
Checklist