Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core-webhooks): increase test coverage to 100% #3867

Merged
merged 3 commits into from Jul 3, 2020

Conversation

sebastijankuzner
Copy link
Contributor

Summary

PR increases core-webhooks coverage to 100%.

Checklist

  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #3867 into develop will increase coverage by 79.38%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3867       +/-   ##
============================================
+ Coverage    12.83%   92.21%   +79.38%     
============================================
  Files          620      620               
  Lines        14840    14840               
  Branches      1842     1842               
============================================
+ Hits          1904    13684    +11780     
+ Misses       12823      946    -11877     
- Partials       113      210       +97     
Flag Coverage Δ
#functional 6.11% <ø> (ø)
#integration 9.56% <ø> (ø)
#unit 90.62% <ø> (?)
Impacted Files Coverage Δ
packages/core-p2p/src/hapi-nes/client.ts 2.83% <0.00%> (+2.83%) ⬆️
packages/core-p2p/src/hapi-nes/socket.ts 2.89% <0.00%> (+2.89%) ⬆️
packages/core-p2p/src/hapi-nes/listener.ts 3.93% <0.00%> (+3.93%) ⬆️
...ore-test-framework/src/app/generators/generator.ts 100.00% <0.00%> (+5.88%) ⬆️
packages/core-test-framework/src/utils/api.ts 97.34% <0.00%> (+6.19%) ⬆️
packages/core-api/src/controllers/locks.ts 100.00% <0.00%> (+9.52%) ⬆️
packages/core-api/src/controllers/delegates.ts 100.00% <0.00%> (+10.81%) ⬆️
...re-test-framework/src/utils/transaction-factory.ts 98.86% <0.00%> (+11.93%) ⬆️
...s/core-test-framework/src/app/generators/crypto.ts 100.00% <0.00%> (+13.13%) ⬆️
...s/core-api/src/resources/transaction-with-block.ts 100.00% <0.00%> (+15.38%) ⬆️
... and 555 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f041b3...8a8246a. Read the comment docs.

@faustbrian faustbrian merged commit 68bc033 into develop Jul 3, 2020
@ghost ghost deleted the test/core-webhooks/increase-coverage branch July 3, 2020 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants