Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-transactions): version 1 multi-signature handler should check milestone data #3871

Merged
merged 2 commits into from
Jul 3, 2020

Conversation

bertiespell
Copy link
Contributor

Summary

The MultiSignatureRegistrationTransactionHandler (version 1) was always returning false for .isActivated() - this PR updates it to instead check milestones.

Fixes #3866. Stops DeactivatedTransactionHandlerError from being thrown while syncing with devnet.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low labels Jul 3, 2020
@bertiespell bertiespell changed the title fix(core-transactions): version 1 multisignature handler should check… fix(core-transactions): version 1 multisignature handler should check milestone data Jul 3, 2020
@bertiespell bertiespell changed the title fix(core-transactions): version 1 multisignature handler should check milestone data fix(core-transactions): version 1 multi-signature handler should check milestone data Jul 3, 2020
@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #3871 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3871   +/-   ##
========================================
  Coverage    92.18%   92.18%           
========================================
  Files          620      620           
  Lines        14850    14850           
  Branches      1844     1844           
========================================
  Hits         13690    13690           
  Misses         948      948           
  Partials       212      212           
Flag Coverage Δ
#functional 6.47% <0.00%> (ø)
#integration 9.56% <0.00%> (ø)
#unit 90.60% <100.00%> (ø)
Impacted Files Coverage Δ
...s/src/handlers/one/multi-signature-registration.ts 96.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68bc033...2956685. Read the comment docs.

@air1one air1one merged commit 74e1e37 into develop Jul 3, 2020
@ghost ghost deleted the fix/multi-signature-handler-active branch July 3, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants