Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): remove excess code from hapi-nes #3878

Merged
merged 11 commits into from
Jul 7, 2020

Conversation

sebastijankuzner
Copy link
Contributor

Summary

This PR solves issue #3868.

Checklist

  • Tests (TBD)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #3878 into develop will increase coverage by 2.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3878      +/-   ##
===========================================
+ Coverage    91.93%   94.22%   +2.28%     
===========================================
  Files          616      616              
  Lines        14793    14421     -372     
  Branches      1842     1733     -109     
===========================================
- Hits         13600    13588      -12     
+ Misses         976      616     -360     
  Partials       217      217              
Flag Coverage Δ
#functional 6.68% <ø> (+0.16%) ⬆️
#integration 9.88% <ø> (+0.24%) ⬆️
#unit 92.57% <ø> (+2.24%) ⬆️
Impacted Files Coverage Δ
packages/core-p2p/src/hapi-nes/client.ts 3.60% <ø> (+0.76%) ⬆️
packages/core-p2p/src/hapi-nes/listener.ts 8.33% <ø> (+4.39%) ⬆️
packages/core-p2p/src/hapi-nes/socket.ts 4.09% <ø> (+1.19%) ⬆️
...ackages/core-magistrate-transactions/src/errors.ts 91.42% <0.00%> (-2.86%) ⬇️
...te-transactions/src/handlers/magistrate-handler.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c8b07...9b049f7. Read the comment docs.

@air1one air1one merged commit f0fe8b9 into develop Jul 7, 2020
@ghost ghost deleted the refactor/core-p2p/hapi-nes branch July 7, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants