Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-database): guaranteed transaction order #3879

Merged
merged 8 commits into from
Jul 9, 2020

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Jul 8, 2020

Summary

Fixes #3870. Takes 30m to execute migration that adds block_height column.

Checklist

  • Ready to be merged

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #3879 into develop will increase coverage by 0.00%.
The diff coverage is 95.12%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3879   +/-   ##
========================================
  Coverage    94.22%   94.23%           
========================================
  Files          616      617    +1     
  Lines        14421    14440   +19     
  Branches      1733     1736    +3     
========================================
+ Hits         13588    13607   +19     
  Misses         616      616           
  Partials       217      217           
Flag Coverage Δ
#functional 6.75% <56.09%> (+0.07%) ⬆️
#integration 9.86% <0.00%> (-0.02%) ⬇️
#unit 92.50% <41.46%> (-0.07%) ⬇️
Impacted Files Coverage Δ
...e-database/src/repositories/abstract-repository.ts 96.66% <90.47%> (+0.51%) ⬆️
...ackages/core-database/src/block-history-service.ts 56.41% <100.00%> (+2.35%) ⬆️
...0-add-block-height-column-to-transactions-table.ts 100.00% <100.00%> (ø)
packages/core-database/src/model-converter.ts 57.14% <100.00%> (+1.58%) ⬆️
packages/core-database/src/models/transaction.ts 100.00% <100.00%> (ø)
...s/core-database/src/transaction-history-service.ts 61.90% <100.00%> (+2.93%) ⬆️
...es/core-snapshots/src/codecs/message-pack-codec.ts 100.00% <100.00%> (ø)
packages/core-test-framework/src/utils/mapper.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0fe8b9...503a360. Read the comment docs.

@rainydio rainydio marked this pull request as ready for review July 8, 2020 12:21
@air1one air1one merged commit 110ada8 into develop Jul 9, 2020
@ghost ghost deleted the fix/core-database/guaranteed-transaction-order branch July 9, 2020 09:12
@ghost ghost removed the Status: Needs Review label Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants