Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-p2p): implement peer blacklisting #3898

Merged
merged 3 commits into from
Jul 20, 2020
Merged

Conversation

sebastijankuzner
Copy link
Contributor

Summary

This PR implements missing peer blacklisting. Additionally isBlacklisted function was added to core-kernel.

Checklist

  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #3898 into develop will decrease coverage by 1.79%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3898      +/-   ##
===========================================
- Coverage    97.61%   95.82%   -1.80%     
===========================================
  Files          620      628       +8     
  Lines        14442    14527      +85     
  Branches      1725     1728       +3     
===========================================
- Hits         14098    13920     -178     
- Misses         155      418     +263     
  Partials       189      189              
Flag Coverage Δ
#functional ?
#integration 9.83% <0.00%> (-0.04%) ⬇️
#unit 95.76% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-kernel/src/utils/is-blacklisted.ts 100.00% <100.00%> (ø)
packages/core-p2p/src/peer-processor.ts 100.00% <100.00%> (ø)
...rc/migrations/20190307000000-drop-wallets-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...c/migrations/20180305200000-create-rounds-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...c/migrations/20180305300000-create-blocks-table.ts 0.00% <0.00%> (-100.00%) ⬇️
.../migrations/20180305100000-create-wallets-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...igrations/20190626000000-enforce-chained-blocks.ts 0.00% <0.00%> (-100.00%) ⬇️
...rations/20191003000000-migrate-vendor-field-hex.ts 0.00% <0.00%> (-100.00%) ⬇️
...ations/20180305400000-create-transactions-table.ts 0.00% <0.00%> (-100.00%) ⬇️
.../20190718000000-check_previous_block-add-schema.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47d3cf2...7c07d3c. Read the comment docs.

@air1one air1one merged commit f18928d into develop Jul 20, 2020
@ghost ghost deleted the feat/core-p2p/blacklist branch July 20, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants