Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-api): fix transactions/${id} confirmations and timestamp fields #3925

Merged
merged 5 commits into from Aug 3, 2020

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Aug 3, 2020

Summary

Quick fix of #3891 until I finish with #3911

Checklist

  • Ready to be merged

@ghost ghost added Complexity: Low labels Aug 3, 2020
@rainydio rainydio changed the title Quick fix transaction show method fix(core-api): fix transactions/${id} confirmations and timestamp field Aug 3, 2020
@rainydio rainydio changed the title fix(core-api): fix transactions/${id} confirmations and timestamp field fix(core-api): fix transactions/${id} confirmations and timestamp fields Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #3925 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3925   +/-   ##
========================================
  Coverage    97.56%   97.56%           
========================================
  Files          629      629           
  Lines        14535    14539    +4     
  Branches      1728     1729    +1     
========================================
+ Hits         14181    14185    +4     
  Misses         165      165           
  Partials       189      189           
Flag Coverage Δ
#functional 6.82% <0.00%> (-0.01%) ⬇️
#integration 9.85% <100.00%> (+0.02%) ⬆️
#unit 95.72% <40.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-api/src/controllers/transactions.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2da0bd...950e622. Read the comment docs.

@rainydio rainydio marked this pull request as ready for review August 3, 2020 15:07
@rainydio
Copy link
Contributor Author

rainydio commented Aug 3, 2020

There is some race in __tests__/functional/transaction-forging/htlc-lock.test.ts and I disabled parallel execution for core-p2p unit tests.

@air1one air1one merged commit a7b46a9 into develop Aug 3, 2020
@ghost ghost deleted the fix/core-api/transaction-show branch August 3, 2020 17:27
@ghost ghost removed the Status: Needs Review label Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants