Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-api): fix order in delegates/{id}/blocks #3932

Merged
merged 1 commit into from Aug 6, 2020

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Aug 5, 2020

Summary

Order block by height:desc for delegates/{id}/blocks

@ghost ghost added Complexity: Low labels Aug 5, 2020
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #3932 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3932   +/-   ##
========================================
  Coverage    97.56%   97.56%           
========================================
  Files          629      629           
  Lines        14540    14540           
  Branches      1729     1729           
========================================
  Hits         14186    14186           
  Misses         165      165           
  Partials       189      189           
Flag Coverage Δ
#functional 6.82% <ø> (ø)
#integration 9.85% <ø> (ø)
#unit 95.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-api/src/routes/delegates.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08d8c93...90d6085. Read the comment docs.

@rainydio rainydio marked this pull request as ready for review August 5, 2020 20:20
@air1one air1one merged commit 50492b4 into develop Aug 6, 2020
@ghost ghost deleted the fix/core-api/delegates-blocks-order branch August 6, 2020 13:44
@ghost ghost removed the Status: Needs Review label Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants