Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-kernel): boot without .env file #3934

Closed

Conversation

sebastijankuzner
Copy link
Contributor

Summary

This PR solves #3929

Changes:

  1. If .env file is not present program log alert and starts
  2. If variable is set in process and in .env, variable from process (system) is taken

Checklist

  • Tests (if necessary)
  • Ready to be merged

@sebastijankuzner sebastijankuzner changed the title Fix/core kernel/start without .env file fix(core-kernal): boot without .env file Aug 5, 2020
@sebastijankuzner sebastijankuzner changed the title fix(core-kernal): boot without .env file fix(core-kernel): boot without .env file Aug 5, 2020
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #3934 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3934   +/-   ##
========================================
  Coverage    97.56%   97.56%           
========================================
  Files          629      629           
  Lines        14540    14543    +3     
  Branches      1729     1730    +1     
========================================
+ Hits         14186    14189    +3     
  Misses         165      165           
  Partials       189      189           
Flag Coverage Δ
#functional 6.82% <0.00%> (-0.01%) ⬇️
#integration 9.85% <0.00%> (-0.01%) ⬇️
#unit 95.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...el/src/bootstrap/app/load-environment-variables.ts 100.00% <100.00%> (ø)
...s/core-kernel/src/services/config/drivers/local.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08d8c93...f0f8c7c. Read the comment docs.

@faustbrian
Copy link
Contributor

If .env file is not present program log alert and starts was discussed in Slack and I said there we won't allow booting without that file because it contains the defaults for every network.

@sebastijankuzner
Copy link
Contributor Author

In this case I am closing pull request.

@sebastijankuzner sebastijankuzner deleted the fix/core-kernel/start-without-.env-file branch November 19, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants