Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-state): fix delegate search order #3939

Merged
merged 4 commits into from Aug 13, 2020

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Aug 7, 2020

Summary

Fixes #3914.

@ghost ghost added Complexity: Low labels Aug 7, 2020
@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #3939 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3939   +/-   ##
========================================
  Coverage    97.56%   97.57%           
========================================
  Files          629      629           
  Lines        14541    14535    -6     
  Branches      1730     1728    -2     
========================================
- Hits         14187    14182    -5     
  Misses         165      165           
+ Partials       189      188    -1     
Flag Coverage Δ
#functional 6.82% <0.00%> (+<0.01%) ⬆️
#integration 9.85% <0.00%> (-0.01%) ⬇️
#unit 95.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/core-state/src/wallets/utils/get-property.ts 100.00% <100.00%> (ø)
...kages/core-state/src/wallets/utils/sort-entries.ts 100.00% <100.00%> (+5.55%) ⬆️
packages/core-api/src/server.ts 100.00% <0.00%> (ø)
packages/core-api/src/schemas.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 640b9a1...70306f3. Read the comment docs.

@rainydio rainydio changed the title fix(core-state): Fix delegate search order fix(core-state): fix delegate search order Aug 10, 2020
@rainydio rainydio marked this pull request as ready for review August 12, 2020 11:40
@air1one air1one merged commit f21af37 into develop Aug 13, 2020
@ghost ghost deleted the fix/core-state/delegate-rank-ordering branch August 13, 2020 10:25
@ghost ghost removed the Status: Needs Review label Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants