Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core-database): use GIN index on transactions.asset #3949

Merged
merged 1 commit into from Aug 11, 2020

Conversation

sebastijankuzner
Copy link
Contributor

Summary

This PR solves: #3947

Using GIN index for transactions.asset (JSONB type) instead default B-TREE index.

Checklist

  • Ready to be merged

@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #3949 into develop will decrease coverage by 83.80%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3949       +/-   ##
============================================
- Coverage    97.56%   13.75%   -83.81%     
============================================
  Files          629      629               
  Lines        14540    14539        -1     
  Branches      1730     1730               
============================================
- Hits         14186     2000    -12186     
- Misses         165    12424    +12259     
+ Partials       189      115       -74     
Flag Coverage Δ
#functional 6.82% <0.00%> (+<0.01%) ⬆️
#integration 9.84% <0.00%> (+<0.01%) ⬆️
#unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-database/src/database-service.ts 0.00% <ø> (-97.23%) ⬇️
...00317000000-add-blocks-and-transactions-indexes.ts 100.00% <ø> (ø)
...ackages/core-transactions/src/handlers/two/ipfs.ts 0.00% <0.00%> (-85.72%) ⬇️
packages/core/src/cli.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/errors.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/schemas.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core/src/commands/top.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-cli/src/contracts.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-forger/src/errors.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/constants.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 562 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ff67a9...682190c. Read the comment docs.

@sebastijankuzner sebastijankuzner force-pushed the chore/core-database/use-gin-index branch from 8f41784 to 682190c Compare August 11, 2020 16:16
@air1one air1one merged commit 37ac35e into develop Aug 11, 2020
@ghost ghost deleted the chore/core-database/use-gin-index branch August 11, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants