Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-api): limit parameter (rollback #3940) #3953

Merged
merged 2 commits into from Aug 12, 2020
Merged

Conversation

rainydio
Copy link
Contributor

Summary

Rollback recent #3940, fixes #3952, add limit parameter test.

Checklist

  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #3953 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3953   +/-   ##
========================================
  Coverage    97.57%   97.57%           
========================================
  Files          629      629           
  Lines        14540    14541    +1     
  Branches      1730     1730           
========================================
+ Hits         14187    14188    +1     
  Misses         165      165           
  Partials       188      188           
Flag Coverage Δ
#functional 6.82% <0.00%> (-0.01%) ⬇️
#integration 9.85% <100.00%> (+<0.01%) ⬆️
#unit 95.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-api/src/schemas.ts 100.00% <100.00%> (ø)
packages/core-api/src/server.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ac35e...3b92b7e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants