chore(core-state): remove forget methods and use index instead

[sebastijankuzner]

Summary

Remove all forget* methods on wallet-repository. Re implements index methods, which now forget wallet from all indexes and re add them back to keep consistency and integrity.

Checklist

• Tests
• Ready to be merged

[codecov]

Codecov Report

Merging #3962 into develop will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #3962      +/-   ##
===========================================
- Coverage    97.57%   97.56%   -0.02%     
===========================================
  Files          629      630       +1     
  Lines        14536    14557      +21     
  Branches      1728     1732       +4     
===========================================
+ Hits         14184    14203      +19     
  Misses         165      165              
- Partials       187      189       +2     

Flag	Coverage Δ
#functional	6.81% <0.00%> (-0.01%)	⬇️
#integration	9.89% <0.00%> (+0.04%)	⬆️
#unit	95.73% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...transactions/src/handlers/business-registration.ts	97.50% <ø> (-0.12%)	⬇️
...-transactions/src/handlers/business-resignation.ts	90.47% <100.00%> (-0.44%)	⬇️
packages/core-state/src/wallets/wallet-index.ts	100.00% <100.00%> (ø)
...ckages/core-state/src/wallets/wallet-repository.ts	92.08% <100.00%> (-0.44%)	⬇️
...sactions/src/handlers/one/delegate-registration.ts	90.90% <100.00%> (ø)
...nsactions/src/handlers/two/delegate-resignation.ts	100.00% <100.00%> (ø)
...ate/src/wallets/wallet-repository-copy-on-write.ts	94.73% <0.00%> (-5.27%)	⬇️
packages/core-database/src/database-service.ts	96.90% <0.00%> (-0.32%)	⬇️
packages/core-state/src/stores/state.ts	100.00% <0.00%> (ø)
packages/core-blockchain/src/blockchain.ts	96.81% <0.00%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f21af37...ab6a63e. Read the comment docs.