-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core-blockchain): initialize blockchain when resolved first time #3969
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3969 +/- ##
===========================================
+ Coverage 95.69% 97.44% +1.75%
===========================================
Files 631 631
Lines 14583 14582 -1
Branches 1733 1734 +1
===========================================
+ Hits 13955 14210 +255
+ Misses 437 181 -256
Partials 191 191
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I tried to reuse This in itself is worth merging anyway. |
…:ArkEcosystem/core into refactor/core-blockchain/lazy-initialize
Summary
Blockchain
class was resolved duringregister
, which chain-resolved wallet repository and all wallet indices which were registered, any wallet index that is registered afterwards wasn't available.The reason why it was resolved is because
Blockchain
class needed additional constructor logic to setup state machine. I markedinitialize
function with@postConstruct
decorator and removed directresolve
andinitialize
call fromregister
.Now plugin that adds wallet index (e.g.
core-magistrate-transactions
) doesn't have to be registered beforecore-blockchain
.Checklist