Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core-magistrate-transactions): increate coverage to 100 % #3972

Merged
merged 10 commits into from
Aug 25, 2020

Conversation

sebastijankuzner
Copy link
Contributor

Summary

Solves #3971

Increase core-magistrate-transactions to 100 %.

Checklist

  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #3972 into develop will increase coverage by 0.42%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3972      +/-   ##
===========================================
+ Coverage    97.56%   97.99%   +0.42%     
===========================================
  Files          630      631       +1     
  Lines        14557    14577      +20     
  Branches      1732     1729       -3     
===========================================
+ Hits         14203    14285      +82     
+ Misses         165      131      -34     
+ Partials       189      161      -28     
Flag Coverage Δ
#functional 6.80% <0.00%> (-0.01%) ⬇️
#integration 9.88% <0.00%> (-0.02%) ⬇️
#unit 96.16% <100.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ansactions/src/handlers/bridgechain-resignation.ts 100.00% <100.00%> (+3.27%) ⬆️
...te-transactions/src/handlers/bridgechain-update.ts 100.00% <100.00%> (+6.09%) ⬆️
...ctions/src/handlers/entity-subhandlers/register.ts 100.00% <100.00%> (+36.84%) ⬆️
...sactions/src/handlers/entity-subhandlers/update.ts 100.00% <100.00%> (+22.64%) ⬆️
...core-magistrate-transactions/src/wallet-indexes.ts 100.00% <100.00%> (+5.26%) ⬆️
packages/core-database/src/database-service.ts 90.62% <0.00%> (-6.29%) ⬇️
packages/core-database/src/service-provider.ts 91.89% <0.00%> (-0.61%) ⬇️
packages/core-p2p/src/network-monitor.ts 99.62% <0.00%> (-0.38%) ⬇️
packages/core-p2p/src/peer-verifier.ts 100.00% <0.00%> (ø)
packages/core-state/src/service-provider.ts 100.00% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fac635e...5037412. Read the comment docs.

@sebastijankuzner sebastijankuzner changed the title test(core-magistrate-transactions): increate coverage to 100 % - IN PROGRESS test(core-magistrate-transactions): increate coverage to 100 % Aug 24, 2020
@air1one air1one merged commit 36878fc into develop Aug 25, 2020
@ghost ghost deleted the test/core-magistrate-transactions branch August 25, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants