Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core-magistrate-api): incrase test coverage to 100% #3984

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

sebastijankuzner
Copy link
Contributor

@sebastijankuzner sebastijankuzner commented Aug 28, 2020

Summary

Solves #3978

Increase core-magistrate-transactions to 100 %.

Checklist

  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #3984 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3984   +/-   ##
========================================
  Coverage    96.24%   96.24%           
========================================
  Files          631      631           
  Lines        14577    14577           
  Branches      1729     1729           
========================================
  Hits         14030    14030           
+ Misses         387      386    -1     
- Partials       160      161    +1     
Flag Coverage Δ
#integration 9.88% <ø> (ø)
#unit 96.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-p2p/src/network-monitor.ts 99.62% <0.00%> (-0.38%) ⬇️
...ckages/core-magistrate-api/src/resources/entity.ts 100.00% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36878fc...4615a07. Read the comment docs.

@air1one air1one merged commit b40add4 into develop Aug 28, 2020
@ghost ghost deleted the test/core-magistrate-api/increase-coverage branch August 28, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants