Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace micromatch with nanomatch #3994

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

sebastijankuzner
Copy link
Contributor

@sebastijankuzner sebastijankuzner commented Sep 2, 2020

Summary

Replace micromatch with nanomatch. PR fixes missing dependancy when using core* packages form npm.

Checklist

  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #3994 into develop will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3994      +/-   ##
===========================================
- Coverage    98.12%   98.12%   -0.01%     
===========================================
  Files          631      631              
  Lines        14578    14578              
  Branches      1729     1729              
===========================================
- Hits         14305    14304       -1     
  Misses         130      130              
- Partials       143      144       +1     
Flag Coverage Δ
#functional 6.80% <0.00%> (ø)
#integration 9.88% <50.00%> (ø)
#unit 96.28% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-api/src/plugins/rate-limit.ts 100.00% <100.00%> (ø)
.../core-kernel/src/services/events/drivers/memory.ts 96.61% <100.00%> (ø)
packages/core-p2p/src/network-monitor.ts 99.62% <0.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 934d306...5cd97c4. Read the comment docs.

@faustbrian faustbrian merged commit 4387b1d into develop Sep 3, 2020
@faustbrian faustbrian deleted the fix/core-kernel/use-nanomatch branch September 3, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants