fix(core-state): clone wallet on mempool wallet-repository #3998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastijankuzner
requested review from
air1one,
faustbrian and
kristjank
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #3998 +/- ##
===========================================
- Coverage 98.49% 98.49% -0.01%
===========================================
Files 631 631
Lines 14576 14583 +7
Branches 1731 1732 +1
===========================================
+ Hits 14357 14363 +6
- Misses 128 129 +1
Partials 91 91
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ghost
mentioned this pull request
air1one
approved these changes
Sep 7, 2020
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extend wallet-index with walletKeys method. Clone wallet by walletKeys insted using index. This approach copy exactly stored keys and copy wallet from indexes even if autoIndex is set to false.
Checklist