Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(magistrate): delegate check only needed on entity register #4024

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Sep 11, 2020

Summary

Entity delegate transactions have a specific check against the sender wallet which needs to be a delegate and username must match entity name.

But this check is only needed for register : as an update or resign needs first a register tx where the delegate check was already done.

This also fixes an issue with current implementation where update or resign entity delegate tx would not be accepted because of the name check which was incorrectly implemented.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@faustbrian faustbrian merged commit 64b63b5 into 2.7 Sep 11, 2020
@ghost ghost deleted the fix/entity-delegate-check branch September 11, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants