fix(magistrate): delegate check only needed on entity register #4024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Entity delegate transactions have a specific check against the sender wallet which needs to be a delegate and username must match entity name.
But this check is only needed for register : as an update or resign needs first a register tx where the delegate check was already done.
This also fixes an issue with current implementation where update or resign entity delegate tx would not be accepted because of the name check which was incorrectly implemented.
Checklist