Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-transactions): unvote+vote transaction #4044

Merged
merged 5 commits into from
Sep 18, 2020

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Sep 17, 2020

Fixes #4039

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #4044 into develop will increase coverage by 82.99%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #4044       +/-   ##
============================================
+ Coverage    13.27%   96.27%   +82.99%     
============================================
  Files          715      715               
  Lines        17172    17218       +46     
  Branches      2098     2098               
============================================
+ Hits          2279    16576    +14297     
+ Misses       14785      451    -14334     
- Partials       108      191       +83     
Flag Coverage Δ
#functional 5.99% <0.00%> (-0.01%) ⬇️
#integration 9.93% <0.00%> (-0.01%) ⬇️
#unit 94.47% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/crypto/src/transactions/types/schemas.ts 100.00% <ø> (+100.00%) ⬆️
...ackages/core-transactions/src/handlers/one/vote.ts 100.00% <100.00%> (+100.00%) ⬆️
packages/core-api/src/routes/wallets.ts 64.00% <0.00%> (-36.00%) ⬇️
packages/core-api/src/routes/transactions.ts 64.00% <0.00%> (-36.00%) ⬇️
packages/core-api/src/routes/node.ts 66.66% <0.00%> (-33.34%) ⬇️
packages/core-api/src/routes/blocks.ts 66.66% <0.00%> (-33.34%) ⬇️
packages/core-api/src/routes/delegates.ts 70.58% <0.00%> (-29.42%) ⬇️
packages/core-api/src/routes/locks.ts 73.33% <0.00%> (-26.67%) ⬇️
packages/core-api/src/routes/peers.ts 80.00% <0.00%> (-20.00%) ⬇️
packages/core-api/src/routes/votes.ts 80.00% <0.00%> (-20.00%) ⬇️
... and 644 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3fe09...c0b5299. Read the comment docs.

@rainydio rainydio marked this pull request as ready for review September 18, 2020 10:40
@air1one air1one merged commit 700b9cd into develop Sep 18, 2020
@ghost ghost deleted the feat/core-transactions/unvote-vote-transaction branch September 18, 2020 15:21
@ghost ghost removed the Status: Needs Review label Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants