refactor(core-api): do not bind directly handler to class method to allow extending response #4045
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following up issue #3571 and PR #3928 which allowed to extend api response by getting the registered handler :
Refactor existing core-api routes handlers, using an arrow function to call the class method handler instead of directly binding the handler to the class method. This allow to easily extend the api response as shown in tests in PR #3928 .
(without using the arrow function, we would get issues with
this
when extending api response and calling the original handler)Checklist