Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-blockchain): block download #4057

Merged
merged 6 commits into from
Sep 29, 2020
Merged

fix(core-blockchain): block download #4057

merged 6 commits into from
Sep 29, 2020

Conversation

sebastijankuzner
Copy link
Contributor

@sebastijankuzner sebastijankuzner commented Sep 25, 2020

Summary

This PR fixes #4035.

Changes:

Download blocks until we reach blockchain processing queue limit. If block is not processed due any reason clear queue and remove downloaded blocks. Start downloading again from the latest stored block in the database.

Checklist

  • Ready to be merged

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #4057 into develop will decrease coverage by 0.08%.
The diff coverage is 25.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4057      +/-   ##
===========================================
- Coverage    96.74%   96.65%   -0.09%     
===========================================
  Files          715      715              
  Lines        17190    17204      +14     
  Branches      2088     2090       +2     
===========================================
- Hits         16630    16629       -1     
- Misses         401      416      +15     
  Partials       159      159              
Flag Coverage Δ
#functional 5.98% <0.00%> (-0.01%) ⬇️
#integration 10.02% <0.00%> (-0.01%) ⬇️
#unit 95.30% <25.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/src/processor/handlers/accept-block-handler.ts 92.85% <ø> (ø)
...kchain/src/processor/handlers/exception-handler.ts 100.00% <ø> (ø)
...rc/processor/handlers/invalid-generator-handler.ts 100.00% <ø> (ø)
...kchain/src/processor/handlers/unchained-handler.ts 100.00% <ø> (ø)
.../processor/handlers/verification-failed-handler.ts 100.00% <ø> (ø)
packages/core-blockchain/src/blockchain.ts 91.98% <7.69%> (-4.91%) ⬇️
...s/core-blockchain/src/processor/block-processor.ts 97.95% <100.00%> (+0.02%) ⬆️
...chain/src/state-machine/actions/download-blocks.ts 88.88% <100.00%> (-8.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 448b941...86c1a81. Read the comment docs.

@air1one air1one merged commit da2e563 into develop Sep 29, 2020
@ghost ghost deleted the fix/node-sync branch September 29, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants