test(core-api): increate test coverage to 100% #4061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastijankuzner
requested review from
air1one,
faustbrian and
kristjank
as code owners
ghost
added
Codecov Report
@@ Coverage Diff @@
## develop #4061 +/- ##
============================================
+ Coverage 13.35% 96.74% +83.38%
============================================
Files 715 715
Lines 17188 17190 +2
Branches 2087 2088 +1
============================================
+ Hits 2296 16630 +14334
+ Misses 14786 401 -14385
- Partials 106 159 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@sebastijankuzner conflicts and failing p2p test due to type issues |
# Conflicts: # __tests__/unit/core-api/controllers/locks.test.ts # __tests__/unit/core-api/controllers/wallets.test.ts
air1one
approved these changes
Sep 29, 2020
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solves #4050
Increase core-api coverage to 100 %.
Checklist