Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-kernel): implement Queue#isRunning/isStarted/onDrain/onError/onData methods #4077

Merged
merged 5 commits into from Oct 3, 2020

Conversation

sebastijankuzner
Copy link
Contributor

@sebastijankuzner sebastijankuzner commented Oct 2, 2020

Summary

Refactor Queue from core-kernel with corresponding MemoryQueue and NullQueue implementations.

MemoryQueue will be used in the core-blockchain logic and that is why it implements additional methods:

  • isRunning
  • isStarted
  • onDrain
  • onError
  • onData

Checklist

  • Tests
  • Ready to be merged

@ghost ghost added the Complexity: High label Oct 2, 2020
@sebastijankuzner sebastijankuzner changed the title refector(core-kernel): refactor Queue refactor(core-kernel): refactor Queue Oct 2, 2020
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #4077 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4077   +/-   ##
========================================
  Coverage    96.65%   96.66%           
========================================
  Files          716      716           
  Lines        17212    17239   +27     
  Branches      2091     2094    +3     
========================================
+ Hits         16637    16664   +27     
  Misses         416      416           
  Partials       159      159           
Flag Coverage Δ
#functional 5.97% <0.00%> (-0.01%) ⬇️
#integration 10.04% <0.00%> (-0.02%) ⬇️
#unit 95.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/core-kernel/src/services/queue/drivers/memory.ts 100.00% <100.00%> (ø)
...ges/core-kernel/src/services/queue/drivers/null.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d788d1...cda4952. Read the comment docs.

@faustbrian faustbrian changed the title refactor(core-kernel): refactor Queue feat(core-kernel): implement Queue#isRunning/isStarted/onDrain/onError/onData methods Oct 3, 2020
@faustbrian faustbrian merged commit d807684 into develop Oct 3, 2020
@ghost ghost deleted the refactor/core-kernel/queue branch October 3, 2020 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants