Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-p2p): rename peer storage into repository #4291

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Jan 27, 2021

Summary

Renamed PeerStorage into PeerRepository. Similarly to core-transaction-pool storage is reserved for service that handles storing data to disk.

Checklist

  • Tests
  • Ready to be merged

@codecov-io
Copy link

Codecov Report

Merging #4291 (294450d) into develop (af4a58f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4291      +/-   ##
===========================================
- Coverage    96.04%   96.04%   -0.01%     
===========================================
  Files          729      729              
  Lines        18013    18012       -1     
  Branches      2207     2207              
===========================================
- Hits         17300    17299       -1     
  Misses         521      521              
  Partials       192      192              
Flag Coverage Δ
functional 5.85% <2.43%> (+<0.01%) ⬆️
integration 9.68% <12.19%> (+<0.01%) ⬆️
unit 94.61% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-kernel/src/ioc/identifiers.ts 100.00% <ø> (ø)
packages/core-api/src/controllers/peers.ts 100.00% <100.00%> (ø)
packages/core-blockchain/src/blockchain.ts 100.00% <100.00%> (ø)
packages/core-p2p/src/listeners.ts 100.00% <100.00%> (ø)
packages/core-p2p/src/network-monitor.ts 98.89% <100.00%> (ø)
packages/core-p2p/src/network-state.ts 100.00% <100.00%> (ø)
packages/core-p2p/src/peer-processor.ts 100.00% <100.00%> (ø)
packages/core-p2p/src/peer-repository.ts 100.00% <100.00%> (ø)
packages/core-p2p/src/service-provider.ts 100.00% <100.00%> (ø)
...ges/core-p2p/src/socket-server/controllers/peer.ts 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af4a58f...294450d. Read the comment docs.

@rainydio rainydio marked this pull request as ready for review January 29, 2021 14:00
@faustbrian faustbrian merged commit bdb6ce7 into develop Jan 29, 2021
@faustbrian faustbrian deleted the refactor/core-p2p/rename-storage-into-repository branch January 29, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants