Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo/v1tablefix #800

Merged
merged 5 commits into from Aug 3, 2018
Merged

Todo/v1tablefix #800

merged 5 commits into from Aug 3, 2018

Conversation

tpscrpt
Copy link
Contributor

@tpscrpt tpscrpt commented Aug 2, 2018

Proposed changes

Reduce visual bloat from commonly used block.js model by moving v1fix outlook values to the crypto lib constants file.

Add tests to crypto's block model to verify whether a block gets changed by the v1applyfix function or remains the same based on its ID.

Everything passes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

#774 , hope this PR is formatted properly

@faustbrian faustbrian merged commit 9664f5d into ArkEcosystem:master Aug 3, 2018
@tpscrpt tpscrpt deleted the todo/v1tablefix branch August 3, 2018 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants