Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Windows support for building crypto and client #842

Merged
merged 1 commit into from Aug 10, 2018

Conversation

ciband
Copy link
Contributor

@ciband ciband commented Aug 10, 2018

Proposed changes

Added support for building crypto and client on Windows. Explicit calls to "rm" have been replaced with the rimraf package to provide a platform agnostic way to delete a directory.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe: build system

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fixes: #841

Added support for building crypto and client on Windows.  Explicit calls to "rm" have been replaced with the rimraf package to provide a platform agnostic way to delete a directory.
@codecov-io
Copy link

Codecov Report

Merging #842 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #842   +/-   ##
=======================================
  Coverage   44.05%   44.05%           
=======================================
  Files         426      426           
  Lines        6993     6993           
  Branches      885      885           
=======================================
  Hits         3081     3081           
  Misses       3376     3376           
  Partials      536      536

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad0c3d2...8172903. Read the comment docs.

@faustbrian faustbrian merged commit f693bf2 into ArkEcosystem:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crypto and client do not build on Windows
3 participants