Nice GQL tests config

[tpscrpt]

Proposed changes

Goal was to optimize the tests to remove unrelated plugins, the required ones are Logger, Logger-Winston and I've found it easier to set a local variable with the require('../lib').register(container, options) as the graphql plugin rather than include it into the config/plugins.js copied from core/config/testnet/* (I was getting undefined issues cause I suck at async) -- now tests pass in a few seconds.

There's an issue with tests running indefinitely if you don't use forceExit which I think the core-container causes (can't see why most plugins would return the same error without --detectOpenHandles and no --forceExit) so I've changed the package.json file to use both and --runInBand (don't know what --rIB does, saw it in some other plugins, thought it was "good").

Tried to remove as much redundancy and will be working on this further.

Types of changes

• [ x ] Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• [ x ] Refactoring (improve a current implementation without adding a new feature or fixing a bug)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Build (changes that affect the build system)
• Docs (documentation only changes)
• [ x ] Test (adding missing tests or fixing existing tests)
• Other... Please describe:

Checklist

• [ x ] I have read the CONTRIBUTING documentation
• [ x ] Lint and unit tests pass locally with my changes (somereason I'm getting trolled)
• [ x ] I have added tests that prove my fix is effective or that my feature works
• [ x ] I have added necessary documentation (if appropriate)

In line with #816

[faustbrian]

detectOpenHandles replaces forceExit

[tpscrpt]

Thanks

[tpscrpt]

Ok, sorry I'll read some jest, I'll remove detectOpenHandles too

[faustbrian]

Also please use [x] instead of [ x ] in your PRs or the to-do lists won't work. You can see that it doesn't render checkboxes.

[faustbrian]

This is still wrong, forceExit is replaced by detectOpenHandles.

[tpscrpt]

what do you suggest?

[faustbrian]

As I said, use --detectOpenHandles instead of --forceExit.

[tpscrpt]

works locally now with proper plugin management (doesnt hang with detectopenhandles)

[codecov-io]

Codecov Report

Merging #854 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #854      +/-   ##
==========================================
- Coverage   43.96%   43.94%   -0.02%     
==========================================
  Files         426      426              
  Lines        7033     7033              
  Branches      894      894              
==========================================
- Hits         3092     3091       -1     
- Misses       3398     3399       +1     
  Partials      543      543

Impacted Files	Coverage Δ
packages/core-p2p/lib/utils/check-ntp.js	78.57% <0%> (-7.15%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8102f23...913159c. Read the comment docs.