Don't load .env in test environment #928
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #928 +/- ##
===========================================
- Coverage 51.65% 51.63% -0.02%
===========================================
Files 432 432
Lines 7200 7202 +2
Branches 924 925 +1
===========================================
Hits 3719 3719
- Misses 3049 3050 +1
- Partials 432 433 +1
Continue to review full report at Codecov.
|
|
If this is a travis specific issue you should use |
|
@faustbrian It's not an issue with travis, since there's no If the container reads an Another solution would be to change |
|
If we no longer load the .env file for testnet the local testing can become quite painful. I have an .env file that I use to store all my testnet configuration that I copy between local and server so I can always have the exact same config. I will take a closer look when I am back tomorrow. |
| if (process.env.ARK_ENV === 'test') { | ||
| return | ||
| } | ||
|
|
||
| const envPath = expandHomeDir(`${process.env.ARK_PATH_DATA}/.env`) | ||
|
|
||
| if (fs.existsSync(envPath)) { |
There was a problem hiding this comment.
Shouldn't this already prevent the loading of any file if it doesn't exist?
Codecov Report
@@ Coverage Diff @@
## develop #928 +/- ##
===========================================
- Coverage 52.71% 52.71% -0.01%
===========================================
Files 436 436
Lines 7280 7282 +2
Branches 940 941 +1
===========================================
+ Hits 3838 3839 +1
Misses 3014 3014
- Partials 428 429 +1
Continue to review full report at Codecov.
|
Proposed changes
The
~/.ark/.envdoesn't exist on Travis, so it makes sense to not even attempt to load itwhen
ARK_ENV=testis true.This fixes an issue I ran into when running tests (core-forger) locally:
Since the container loaded my
.envand thus setARK_P2P_PORTto4002, which causedprocess.env.ARK_P2P_PORT || 4000fromcore/lib/config/testnet/plugins.jsto return the wrong port.Checklist